Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 20654 m25 int #13886

Merged
merged 11 commits into from
Oct 14, 2024
Merged

B 20654 m25 int #13886

merged 11 commits into from
Oct 14, 2024

Conversation

deandreJones
Copy link
Contributor

B-20654

Summary

Is there anything you would like reviewers to give additional scrutiny?

Adding the ability to store/save the generated 858s in the system and view them in the admin app

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Access the test harness scenarios and run 'MakeMoveReadyForEdi'image
  2. grab the payment request number from the payload
    image
  3. run go run ./cmd/generate-payment-request-edi/ --payment-request-number 9641-6802-1
  4. see a new record in payment_request_edi_files for that payment_request_number and the edi should match what's showing in terminal output
  5. access Admin app
  6. select Payment Request Syncada Files link on left nav
  7. click the row of payment request number from above
  8. validate the edi string is the same from db and terminal output
    image

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

@deandreJones deandreJones requested a review from a team as a code owner October 11, 2024 17:21
@deandreJones deandreJones added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Oct 11, 2024
@robot-mymove
Copy link

robot-mymove commented Oct 11, 2024

Warnings
⚠️

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?

View the frontend file org ADR for more information

⚠️ This PR does not include changes to unit tests, even though it affects app code.

Generated by 🚫 dangerJS against 854b51e

Copy link
Contributor

@traskowskycaci traskowskycaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
image

Copy link
Contributor

@TevinAdams TevinAdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected. Reviewed code and didn't find any issues.

@deandreJones deandreJones merged commit 84563d4 into integrationTesting Oct 14, 2024
30 checks passed
@deandreJones deandreJones deleted the B-20654-M25-INT branch October 14, 2024 14:50
@deandreJones deandreJones mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

5 participants